Make local block filter return empty list when when no blocks mined #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjw
force-pushed
the
fix_local_filter_error
branch
from
a0b18db
to
4fb4d01
Compare
|
@kclowes @njgheorghita Do either of you have a moment to review this? |
pipermerriam
reviewed
Apr 2, 2019
web3/middleware/filter.py
Outdated
| @@ -277,6 +277,8 @@ def get_filter_changes(self): | |||
| @to_list | |||
| def block_hashes_in_range(w3, block_range): | |||
| from_block, to_block = block_range | |||
| if from_block is None or to_block is None: | |||
| return None | |||
There was a problem hiding this comment.
I think this should just be return. The value from a return statement in a generator doesn't actually get returned.
There was a problem hiding this comment.
If we get flake8-bugbear added to the lint run for this repo it will catch things like this (by explicitely enabling B901)
kclowes
force-pushed
the
fix_local_filter_error
branch
from
4fb4d01
to
cb8ddf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1253
Cute Animal Picture