-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old geth versions #1709
Remove old geth versions #1709
Conversation
6424633
to
a59b358
Compare
@@ -121,3 +121,6 @@ fabric.properties | |||
|
|||
# pip wheel metadata | |||
pip-wheel-metadata/ | |||
|
|||
# jupyter notebook files | |||
*.ipynb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
@@ -73,7 +73,7 @@ | |||
"eth-account>=0.5.2,<0.6.0", | |||
"eth-hash[pycryptodome]>=0.2.0,<1.0.0", | |||
"eth-typing>=2.0.0,<3.0.0", | |||
"eth-utils>=1.8.4,<2.0.0", | |||
"eth-utils>=1.8.4,<1.9.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: the revert message work will require a later eth-utils version. Without it, EthereumTesterProvider won't receive revert messages. Can be figured out later.
assert version == '5.0' | ||
else: | ||
assert version == '6.0' | ||
assert version == '6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - latest version(s) of Geth removed Whisper from the distro, so when we bump to the latest version, maybe we want to look at dropping support for it in Web3.py.
What was wrong?
We decided we didn't need to support Geth versions past the most recent hard fork, since the Geth team doesn't support anything beyond the latest version.
Related to Issue #1703
How was it fixed?
Removed all old Geth tests and fixtures.
Todo:
Cute Animal Picture