-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old geth versions #1709
Remove old geth versions #1709
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,3 +121,6 @@ fabric.properties | |
|
||
# pip wheel metadata | ||
pip-wheel-metadata/ | ||
|
||
# jupyter notebook files | ||
*.ipynb | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Remove 1.8 and 1.7 Geth tests, since the Geth team only supports the latest version. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,7 +73,7 @@ | |
"eth-account>=0.5.2,<0.6.0", | ||
"eth-hash[pycryptodome]>=0.2.0,<1.0.0", | ||
"eth-typing>=2.0.0,<3.0.0", | ||
"eth-utils>=1.8.4,<2.0.0", | ||
"eth-utils>=1.8.4,<1.9.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI: the revert message work will require a later eth-utils version. Without it, EthereumTesterProvider won't receive revert messages. Can be figured out later. |
||
"hexbytes>=0.1.0,<1.0.0", | ||
"ipfshttpclient>=0.4.13,<1", | ||
"jsonschema>=3.2.0,<4.0.0", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -393,10 +393,7 @@ def test_shh_post_deprecated(self, web3: "Web3") -> None: | |
# | ||
def test_shh_version(self, web3: "Web3") -> None: | ||
version = web3.geth.shh.version() | ||
if '1.7' in web3.clientVersion: | ||
assert version == '5.0' | ||
else: | ||
assert version == '6.0' | ||
assert version == '6.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI - latest version(s) of Geth removed Whisper from the distro, so when we bump to the latest version, maybe we want to look at dropping support for it in Web3.py. |
||
|
||
def test_shh_info(self, web3: "Web3") -> None: | ||
pre_info = web3.geth.shh.info() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏