Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release v2.5.0 #394

Merged
merged 2 commits into from
Nov 22, 2018
Merged

New release v2.5.0 #394

merged 2 commits into from
Nov 22, 2018

Conversation

holgerd77
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Nov 21, 2018

Coverage Status

Coverage remained the same at 90.465% when pulling 1c268db on new-release-v250 into 852bde7 on master.

CHANGELOG.md Outdated Show resolved Hide resolved
vpulim
vpulim previously approved these changes Nov 21, 2018
Copy link
Contributor

@vpulim vpulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on this important release! Looks good to me.

Copy link
Contributor

@rmeissner rmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really looking forward to this release :)

EDIT: request for changes was a misclick :/

rmeissner
rmeissner previously approved these changes Nov 21, 2018
@holgerd77
Copy link
Member Author

Ah, @rmeissner, @mattdean-digicatapult, @vpulim, @axic, dismissed all your reviews by a force-push, if someone of you could re-approve I would be happy! 😄

@holgerd77
Copy link
Member Author

@rmeissner Thanks, I was actually live-waiting in front of my laptop, hoping that someone of you would be awake / online / aware / free-of-duties! 😛

Will now merge and then do the release.

@holgerd77 holgerd77 merged commit f906e71 into master Nov 22, 2018
@holgerd77 holgerd77 deleted the new-release-v250 branch November 22, 2018 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants