-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authenticated privacy request route #1819
Conversation
Also only updates the user if the password has changed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, this all looks really good!
just one minor comment on a merge discrepancy that we should fix up. since you're on PTO and would like to get unblocked, i'm gonna make that change myself and hopefully then can just get this merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good to me now!
Co-authored-by: Paul Sanders <[email protected]> Co-authored-by: Adam Sachs <[email protected]>
Closes #1748
Code Changes
Steps to Confirm
parent_server_username
andparent_server_password
to thefides.toml
file.Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats