-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1746 fides connector #1861
Merged
Merged
1746 fides connector #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsachs
force-pushed
the
1746-fides-connector
branch
from
November 28, 2022 15:46
d5dce5c
to
fa68e3e
Compare
adamsachs
commented
Nov 28, 2022
adamsachs
commented
Nov 28, 2022
adamsachs
commented
Nov 28, 2022
adamsachs
commented
Nov 28, 2022
adamsachs
commented
Nov 28, 2022
adamsachs
commented
Nov 28, 2022
adamsachs
commented
Nov 28, 2022
adamsachs
force-pushed
the
1746-fides-connector
branch
from
November 28, 2022 16:03
fa68e3e
to
10719f4
Compare
sanders41
reviewed
Nov 28, 2022
Clean up for mypy and linting
This utility will be used in order to perform post processing on Fides connector results in the graph traversal aggregation.
Use timeouts instead of retries config parameter. Update our config parameters for proper typing and defaulting with new function call.
adamsachs
force-pushed
the
1746-fides-connector
branch
from
November 29, 2022 14:48
685cc10
to
58ce4da
Compare
sanders41
reviewed
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple minor questions/suggestions.
sanders41
approved these changes
Nov 29, 2022
…tor access request Add some fixtures as this requires a sample policy with a local storage destination so that the request can complete successfully.
sanders41
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6 tasks
15 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1746
Closes #1747
Code Changes
fides
connector/connection type that forwards a privacy request to "child" Fides instances whose details are provided via connector config secretsusername
andpassword
) for the child serverfides
connection type is also includedSteps to Confirm
nox -s dev -- child remote_debug
remote_debug
flag is optional but can be useful heredocker exec -ti fides-fides-1 /bin/bash
and thenpython scripts/load_fides_child_examples.py
to configure the fides connector config on the "parent" fideshttp://0.0.0.0:8081
from a host machine)Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Initial implementation of Fides connector functionality. Does not include result aggregation functionality, as that will be covered in a subsequent PR.