Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable connector dropdown in integration tab when null and undefined #3589

Merged
merged 6 commits into from
Jun 20, 2023

Conversation

Kelsey-Ethyca
Copy link
Contributor

Closes #3588

Code Changes

  • add to disabled check that connectionConfig is defined and not null

Steps to Confirm

  • create a new system
  • after clicking save immediately navigate to the integration tab
  • verify the connection type dropdown is enabled

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@cypress
Copy link

cypress bot commented Jun 15, 2023

Passing run #2772 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c460e3c into 9cddb24...
Project: fides Commit: 597cb4cec2 ℹ️
Status: Passed Duration: 00:46 💡
Started: Jun 19, 2023 4:37 AM Ended: Jun 19, 2023 4:38 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Kelsey-Ethyca Kelsey-Ethyca changed the title check connectionConfig is defined and not null disable connector dropdown in integration tab when null and undefined Jun 20, 2023
@Kelsey-Ethyca Kelsey-Ethyca changed the title disable connector dropdown in integration tab when null and undefined Enable connector dropdown in integration tab when null and undefined Jun 20, 2023
@Kelsey-Ethyca Kelsey-Ethyca merged commit a8feeb1 into main Jun 20, 2023
@Kelsey-Ethyca Kelsey-Ethyca deleted the kt-3588-connector-dropdown-bug branch June 20, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AT: connector template drop-down isn't enabled the first time you visit it after creating a system
2 participants