Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable connector dropdown in integration tab when null and undefined #3589

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Enable connector dropdown in integration tab when null and undefined #3589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
524ca42
check connectionConfig is defined and not null
Kelsey-Ethyca Jun 15, 2023
711b0a5
Add enable/disable toggle to intergration tab
Kelsey-Ethyca Jun 16, 2023
0c8f178
Revert "Add enable/disable toggle to intergration tab"
Kelsey-Ethyca Jun 16, 2023
aac6932
update changelog
Kelsey-Ethyca Jun 16, 2023
c460e3c
Merge remote-tracking branch 'origin/main' into kt-3588-connector-dro…
Kelsey-Ethyca Jun 19, 2023
e5ca2ba
Merge branch 'main' into kt-3588-connector-dropdown-bug
Kelsey-Ethyca Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ The types of changes are:
- This PR contains a migration that deletes duplicate users and keeps the oldest original account.
- Update Logos for shipped connectors [#2464](https://github.com/ethyca/fides/pull/2587)
- Search field on privacy request page isn't working [#2270](https://github.com/ethyca/fides/pull/2595)
- Fix connection dropdown in integration table to not be disabled add system creation [#3589](https://github.com/ethyca/fides/pull/3589)

### Developer Experience

Expand Down
2 changes: 1 addition & 1 deletion clients/admin-ui/src/features/datastore-connections/system_portal_config/ConnectionForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const ConnectionForm = ({ connectionConfig, systemFidesKey }: Props) => {
label="Connection type"
selectedValue={selectedConnectionOption}
onChange={setSelectedConnectionOption}
disabled={connectionConfig !== null}
disabled={connectionConfig && connectionConfig !== null}
/>
<Spacer />
{!connectionConfig && orphanedConnectionConfigs.length > 0 ? (
Expand Down