Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reset suggestions from dictionary toggle #3976

Closed
wants to merge 3 commits into from

Conversation

allisonking
Copy link
Contributor

Closes #3962

Description Of Changes

Removes the "reset suggestions" option from the dictionary toggle menu.

Screen.Recording.2023-08-25.at.10.08.06.AM.mov

Code Changes

  • Remove code for "reset suggestions" option
  • Clean up types just a little bit

Steps to Confirm

  • Run fidesplus with the proper environment variables to enable the dictionary service
  • Add a system and choose from the vendor list
  • The sparkle button should now be clickable. Click it and you should only see one option (no more "reset suggestions")

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Aug 25, 2023

Passing run #3726 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4576747 into e136ac6...
Project: fides Commit: 7945729dd7 ℹ️
Status: Passed Duration: 01:50 💡
Started: Aug 25, 2023 5:26 PM Ended: Aug 25, 2023 5:28 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review August 25, 2023 19:03
@TheAndrewJackson
Copy link
Contributor

Closing because this work was handled in #4007

@allisonking allisonking deleted the aking/3962/remove-reset-suggestions branch October 26, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Reset suggestions" option from dictionary toggle
2 participants