Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reset suggestions from dictionary toggle #4007

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

Closes #3962
This is a port of the original PR by @allisonking #3976

Description Of Changes

Removes the "reset suggestions" option from the dictionary toggle menu.

263344715-480afcbd-e444-4d98-b34b-d616a33cbf8c.mov

Code Changes

  • Remove code for "reset suggestions" option
  • Clean up types just a little bit

Steps to Confirm

  • Run fidesplus with the proper environment variables to enable the dictionary service
  • Add a system and choose from the vendor list
  • The sparkle button should now be clickable. Click it and you should only see one option (no more "reset suggestions")

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Aug 31, 2023

Passing run #3860 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 252e361 into 56955c8...
Project: fides Commit: 537e46e148 ℹ️
Status: Passed Duration: 01:07 💡
Started: Aug 31, 2023 3:41 PM Ended: Aug 31, 2023 3:42 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review August 31, 2023 15:44
@TheAndrewJackson TheAndrewJackson merged commit 2879f1c into main Aug 31, 2023
10 checks passed
@TheAndrewJackson TheAndrewJackson deleted the ajackson/3962/remove_reset_suggestions branch August 31, 2023 15:50
TheAndrewJackson added a commit that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Reset suggestions" option from dictionary toggle
2 participants