Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1452- Refactor: extract out getting custom preferences from getting override options #4466

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Nov 29, 2023

Closes https://ethyca.atlassian.net/browse/PROD-1452

Description Of Changes

Refactors getting custom preferences from getting override options such that the API call does not delay our ability to initialize our CMP lib.

Code Changes

  • Refactor GET call out from getting override options
  • Add DEFER comment to explicitly say we currently don't support overriding notice-based custom consent prefs from our getPreferencesFn function.

Steps to Confirm

  • Define a custom get preferences override function for fides.js
  • Call the Fides.init(...) function and provide the override params
  • Immediately after calling init(), check if __tcfapi is defined

Pre-Merge Checklist

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 11:47am

Copy link

cypress bot commented Nov 29, 2023

Passing run #5454 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 6fcaa35 into ed32558...
Project: fides Commit: f544b9c98a ℹ️
Status: Passed Duration: 00:34 💡
Started: Dec 4, 2023 11:57 AM Ended: Dec 4, 2023 11:58 AM

Review all test suite changes for PR #4466 ↗︎

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@eastandwestwind eastandwestwind merged commit 05b5bfd into main Dec 4, 2023
13 checks passed
@eastandwestwind eastandwestwind deleted the PROD-1452 branch December 4, 2023 12:08
@eastandwestwind eastandwestwind mentioned this pull request Dec 4, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants