Add tests for GPP extension #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #5456 ↗︎
Details:
Review all test suite changes for PR #4476 ↗︎ |
|||||||||||||||
allisonking
force-pushed
the
aking/prod-1420/gpp-tests
branch
from
0988139
to
759859c
Compare
eastandwestwind
requested changes
Dec 4, 2023
There was a problem hiding this comment.
looks great, just would like to take care of those TODOs now that #4466 is merged.
eastandwestwind
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1420
Description Of Changes
Adds Cypress tests for the GPP extension!
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md