Add UI for configuring integrations for data detection/discovery #4922
Conversation
…and-Data-Discovery
…and-Data-Discovery
…and-Data-Discovery
…and-Data-Discovery
…scovery' of https://github.com/ethyca/fides into PROD-2050-Configuring-integrations-for-DSRs-and-Data-Discovery
…and-Data-Discovery
| cy.getByTestId(testIdMulti) | ||
| .find(".custom-select__menu-list") | ||
| .contains("Eevee") | ||
| .click(); |
There was a problem hiding this comment.
I honestly have no idea why this PR caused this test to break, but I fixed it! ¯\_(ツ)_/¯
|
|
||
| const isLoading = secretsIsLoading || patchIsLoading || systemPatchIsLoading; | ||
|
|
||
| const initialValues: FormValues = { |
There was a problem hiding this comment.
Note that keyfile credentials aren't included in the initial values even if the user is editing-- the API response just returns "**********" and not populating the form with that is consistent with behavior in the other connection forms.
There was a problem hiding this comment.
Thanks for clarifying. Can we a small comment in the code indicating that?
…scovery' of https://github.com/ethyca/fides into PROD-2050-Configuring-integrations-for-DSRs-and-Data-Discovery
| <> | ||
| <IntegrationBox | ||
| integration={BQ_PLACEHOLDER} | ||
| button={ |
There was a problem hiding this comment.
Is there a need to pass the button to the IntegrationBox component? Is it going to look very different depending on the Integration?
If not, I think it would be better if the button was part of the IntegrationBox component. The IntegrationBox component could then have a "onAccept" or "onConfigure" prop so we can do the "setStep(1)" here.
|
|
||
| const isLoading = secretsIsLoading || patchIsLoading || systemPatchIsLoading; | ||
|
|
||
| const initialValues: FormValues = { |
There was a problem hiding this comment.
Thanks for clarifying. Can we a small comment in the code indicating that?
| </Box> | ||
| ), | ||
| }, | ||
| // { |
There was a problem hiding this comment.
some commented code here we could delete
|
|
||
| const { onOpen, isOpen, onClose } = useDisclosure(); | ||
|
|
||
| // const onTabChange = () => {}; |
There was a problem hiding this comment.
commented code we can delete
jpople
deleted the
PROD-2050-Configuring-integrations-for-DSRs-and-Data-Discovery
branch
Closes PROD-2050, PROD-2055, PROD-2056, PROD-2069, PROD-2070
Description Of Changes
Adds UI for configuring integrations for data detection and discovery.
Code Changes
Steps to Confirm
With "Data detection & discovery" beta flag enabled:
/integrationsPre-Merge Checklist
CHANGELOG.md