Fix duplicate data-testid on system tabs #4952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jpople
changed the title
Passing run #8111 ↗︎
Details:
Review all test suite changes for PR #4952 ↗︎ |
|||||||||||||||
pattisdr
approved these changes
Jun 5, 2024
|
Thank you Jeremy! ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Description Of Changes
A Plus Cypress test was failing due to finding two elements with data-testid
system-tabs, this fixes by removing it from the TabContent element (that testid was newly introduced by #4922 and is not being used).Pre-Merge Checklist
CHANGELOG.md