Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1950 Display all custom fields on privacy request form #5029

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jun 27, 2024

Description Of Changes

Display all fields in privacy request form, even hidden ones.

Code Changes

  • Display all fields in privacy request form
  • Make sure the modal scrolls and doesn't break with multiple custom fields
  • Update tests to reflect that hidden fields should be shown

Steps to Confirm

  • Use API endpoint /api/v1/plus/privacy-center-config PUT request with a privacy center config that has custom request fields
  • Log in admin ui and go to Privacy Request > Request Manager
  • Click on create request
  • Select a request type and confirm that all of the custom request fields (even the hidden ones) are displayed
  • Also, confirm that if there are many custom request fields, the modal alllows to scroll to fill all of them.

Screenshot

Captura de pantalla 2024-07-01 a la(s) 5 03 39 p  m

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 5:20pm

Copy link

cypress bot commented Jun 27, 2024

Passing run #8678 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 332e6c3 into 31bda34...
Project: fides Commit: d9e94190f8 ℹ️
Status: Passed Duration: 00:40 💡
Started: Jul 2, 2024 5:29 PM Ended: Jul 2, 2024 5:30 PM

Review all test suite changes for PR #5029 ↗︎

…tom-fields-to-Admin-UI-privacy-request-submission-form
@lucanovera lucanovera merged commit fe72f73 into main Jul 2, 2024
10 of 11 checks passed
@lucanovera lucanovera deleted the PROD-1950-Add-custom-fields-to-Admin-UI-privacy-request-submission-form branch July 2, 2024 17:17
Copy link

cypress bot commented Jul 2, 2024

Passing run #8679 ↗︎

0 4 0 0 Flakiness 0

Details:

PROD-1950 Display all custom fields on privacy request form (#5029)
Project: fides Commit: fe72f734bc
Status: Passed Duration: 00:41 💡
Started: Jul 2, 2024 5:29 PM Ended: Jul 2, 2024 5:30 PM

Review all test suite changes for PR #5029 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants