PROD-1950 Display all custom fields on privacy request form

CHANGELOG.md

@@ -31,6 +31,7 @@ The types of changes are:
 - Replaces typescript-cookie with js-cookie [#5022](https://github.com/ethyca/fides/pull/5022)
 - Updated pymongo version to 4.7.3 [#5019](https://github.com/ethyca/fides/pull/5019)
 - Upgraded Datamap instance of `react-table` to v8 [#5024](https://github.com/ethyca/fides/pull/5024)
+- Updated create privacy request modal from admin-ui to include all custom fields  [#5029](https://github.com/ethyca/fides/pull/5029)
 - Update name of Ingress/Egress columns in Datamap Report to Sources/Destinations [#5045](https://github.com/ethyca/fides/pull/5045)
 
 ### Fixed

clients/admin-ui/cypress/e2e/privacy-requests.cy.ts

@@ -230,7 +230,7 @@ describe("Privacy Requests", () => {
         ).should("exist");
         cy.getByTestId(
           "input-custom_privacy_request_fields.hidden_field.value"
-        ).should("not.exist");
+        ).should("exist");
         cy.getByTestId(
           "input-custom_privacy_request_fields.field_with_default_value.value"
         ).should("have.value", "The default value");
@@ -245,6 +245,9 @@ describe("Privacy Requests", () => {
         cy.getByTestId(
           "input-custom_privacy_request_fields.required_field.value"
         ).type("A value for the required field");
+        cy.getByTestId(
+          "input-custom_privacy_request_fields.hidden_field.value"
+        ).type("A value for the hidden but required field");
         cy.getByTestId("input-is_verified").click();
         cy.intercept("POST", "/api/v1/privacy-request/authenticated", {
           statusCode: 200,

clients/admin-ui/src/features/privacy-requests/SubmitPrivacyRequest.tsx

@@ -67,7 +67,11 @@ const SubmitPrivacyRequestModal = ({
   return (
     <Modal isOpen={isOpen} onClose={onClose} size="2xl" isCentered>
       <ModalOverlay />
-      <ModalContent data-testid="submit-request-modal">
+      <ModalContent
+        data-testid="submit-request-modal"
+        maxHeight="80%"
+        overflowY="auto"
+      >
         <ModalHeader>Create privacy request</ModalHeader>
         <ModalBody>
           <Stack spacing={4}>

clients/admin-ui/src/features/privacy-requests/SubmitPrivacyRequestForm.tsx

@@ -73,17 +73,15 @@ const CustomFields = ({
   const allInputs = Object.entries(customFieldInputs);
   return (
     <>
-      {allInputs.map(([fieldName, fieldInfo]) =>
-        !fieldInfo.hidden ? (
-          <CustomTextInput
-            name={`custom_privacy_request_fields.${fieldName}.value`}
-            key={fieldName}
-            label={fieldInfo.label}
-            isRequired={fieldInfo.required}
-            variant="stacked"
-          />
-        ) : null
-      )}
+      {allInputs.map(([fieldName, fieldInfo]) => (
+        <CustomTextInput
+          name={`custom_privacy_request_fields.${fieldName}.value`}
+          key={fieldName}
+          label={fieldInfo.label}
+          isRequired={fieldInfo.required}
+          variant="stacked"
+        />
+      ))}
     </>
   );
 };