Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend scaffolding (prettier, navbar, testing) #679

Merged
merged 16 commits into from
May 25, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented May 19, 2022

Some progress towards #676. Wanted to put in a PR before this got too big, since it was already touching a lot of files.

Code Changes

  • Add import sorting similar to fidesops Import sorting via eslint fidesops#514
  • Add baseUrl for easier imports
  • Add prettier
  • Run prettier
  • Refactor Nav bar into a Layout component to make it easier to duplicate across pages
  • Add testing to nav bar

Steps to Confirm

  • Run npm run dev and poke around!

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Not really any big UI changes, but swapped out the fidesops navbar for one that looks more like the one in Balsamiq
image

Also added a page for /dataset but it's empty right now.
image

(that active state for "Datasets" in the nav bar probably isn't what we want it to look like, but I'm not gonna mess with CSS before we have an actual design)

After this, we should be ready to actually display some data on the /dataset route

@allisonking allisonking marked this pull request as ready for review May 20, 2022 13:37
@allisonking allisonking requested review from a team and elliotbonneville and removed request for a team May 20, 2022 13:37
CHANGELOG.md Outdated Show resolved Hide resolved
@allisonking allisonking changed the title 676 minimal dataset api frontend Frontend scaffolding (prettier, navbar, testing) May 20, 2022
Copy link
Contributor

@elliotbonneville elliotbonneville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @allisonking. Love the cleanup work and improvements to tooling, etc. throughout. NavLink is also a well-implemented component. Thanks for cleaning that up.

Just one comment here around a use of any – if you can find away around using it I'm happy to approve!

clients/admin-ui/src/features/common/NavBar.tsx Outdated Show resolved Hide resolved
@allisonking allisonking merged commit 539af04 into main May 25, 2022
@allisonking allisonking deleted the aking-676-dataset-api-frontend branch May 25, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants