-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend scaffolding (prettier, navbar, testing) #679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonking
requested review from
a team and
elliotbonneville
and removed request for
a team
May 20, 2022 13:37
allisonking
changed the title
676 minimal dataset api frontend
Frontend scaffolding (prettier, navbar, testing)
May 20, 2022
elliotbonneville
suggested changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @allisonking. Love the cleanup work and improvements to tooling, etc. throughout. NavLink
is also a well-implemented component. Thanks for cleaning that up.
Just one comment here around a use of any
– if you can find away around using it I'm happy to approve!
elliotbonneville
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some progress towards #676. Wanted to put in a PR before this got too big, since it was already touching a lot of files.
Code Changes
Steps to Confirm
npm run dev
and poke around!Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Not really any big UI changes, but swapped out the fidesops navbar for one that looks more like the one in Balsamiq
Also added a page for
/dataset
but it's empty right now.(that active state for "Datasets" in the nav bar probably isn't what we want it to look like, but I'm not gonna mess with CSS before we have an actual design)
After this, we should be ready to actually display some data on the /dataset route