Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Import sorting via eslint #514

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

elliotbonneville
Copy link
Contributor

Purpose

Implements import sorting via eslint to keep our imports tidy and consistent. Inspired by this conversation.

Note: there's a little bit of eslint noise because I ran eslint . --fix to update all the imports. Can be safely ignored.

Changes

  • Adds eslintignore file
  • Switches package.json lint script from using next lint to eslint
  • Adds the simple-import-sort eslint plugin and configures it

Checklist

  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray, looks great! thanks for doing this!

@elliotbonneville elliotbonneville merged commit 59037da into main May 13, 2022
@elliotbonneville elliotbonneville deleted the feature/import-sorting-eslint branch May 13, 2022 20:53
adamsachs pushed a commit to adamsachs/fidesops_forked_test that referenced this pull request May 17, 2022
* Import import sorting plugin

* Implement import sorting
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* Import import sorting plugin

* Implement import sorting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants