Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐛 in esl-media]: Brightcove Provider some players did not stop after seeking asset to the end #1979

Closed
ala-n opened this issue Oct 12, 2023 · 1 comment · Fixed by #1980
Closed

[🐛 in esl-media]: Brightcove Provider some players did not stop after seeking asset to the end #1979

ala-n opened this issue Oct 12, 2023 · 1 comment · Fixed by #1980
Assignees
@ala-n @abarmina
Labels
bug Something isn't working released
Milestone
⚡ESL: 4.13.0 Mino...

Comments

@ala-n
Copy link
Collaborator

ala-n commented Oct 12, 2023

Some Brightcove videos did not stop when the video was seek to the end and then requested to be stoped.

To Reproduce
Steps to reproduce the behavior:

  1. Setup environment
 <esl-media media-type="brightcove" media-id="..." account-id="..." player-id="..."></esl-media>
  1. Seek video to the end
  2. Call $media.stop();
  3. Observe behaviour

Current behavior
The video restarts and starts playing after the stop method call

Expected behavior
The video stops and seeks to start without autoplay

Possible Solution
Check and update initial autoplay logic hack, presented due to videojs issues
@ala-n ala-n added the bug Something isn't working label Oct 12, 2023
@ala-n ala-n added this to the ⚡ESL: 4.13.0 Minor release milestone Oct 12, 2023
ala-n added a commit that referenced this issue Oct 12, 2023
@ala-n
fix(esl-media): fix brightcove provider autoplay marker flow
28396bc 
Closes: #1979
ala-n added a commit that referenced this issue Oct 12, 2023
@ala-n @abarmina
fix(esl-media): fix brightcove provider autoplay marker flow
58793cd 
Closes: #1979

Co-authored-by: Anna Barmina <[email protected]>
@ala-n ala-n mentioned this issue Oct 12, 2023
Merged
ala-n pushed a commit that referenced this issue Oct 25, 2023
@semantic-release-bot
chore(release): 4.13.0
473b9dd 
# [4.13.0](v4.12.0...v4.13.0) (2023-10-25)

### Bug Fixes

* **esl-media:** fix brightcove provider autoplay marker flow ([58793cd](58793cd)), closes [#1979](#1979)
* **esl-popup:** fix default styles for `esl-popup` tag (uninitialized) ([e25eedf](e25eedf))
* **esl-popup:** update popup position according activator change ([#1679](#1679)) ([65e3801](65e3801))
* **esl-scrollbar:** fix incorrect `at-start`/`at-end` handling when browser creates dimensions with the floating point ([852ad15](852ad15))
* **esl-share:** add a fill color to social network icons ([c0d62ac](c0d62ac))
* **esl-share:** change default twitter (x.com) icon and bg color ([8c544e4](8c544e4))
* **esl-share:** show copy notification just in case it is successful ([f57fe98](f57fe98))
* **esl-utils:** fix `debounce` helper random access of undefined ([8cd87e8](8cd87e8))

### Features

* **esl-event-listener:** add `condition` descriptor property to legally prevent subscription ([00b719c](00b719c)), closes [#1947](#1947)
* **esl-event-listener:** create `ESLIntersectionTarget` adapter utility for managing `IntersectionObserver` subscriptions trough event listeners ([34bb7e8](34bb7e8))
* **esl-share:** add default-icon marker to render icon on button init ([081b526](081b526))
* **esl-share:** add out of the box share config default ([4b97632](4b97632))
* **esl-share:** create esl-share-list component ([90b1c1d](90b1c1d))
* **esl-share:** remove iconBackground property from share buttons config ([27d793d](27d793d))
* **esl-share:** rework esl-share-button custom element API ([96a7f84](96a7f84))
* **esl-share:** rework share popup internal implementation ([9b775a0](9b775a0))
@ala-n
Copy link
Collaborator Author

ala-n commented Oct 25, 2023

🎉 This issue has been resolved in version 4.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ala-n ala-n

@abarmina abarmina

Labels
bug Something isn't working released
Projects
None yet
Milestone
⚡ESL: 4.13.0 Minor release
Development

Successfully merging a pull request may close this issue.

fix(esl-media): fix brightcove provider autoplay marker flow exadel-inc/esl
2 participants
@ala-n @abarmina