Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esl-media): fix brightcove provider autoplay marker flow #1980

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

ala-n
Copy link
Collaborator

@ala-n ala-n commented Oct 12, 2023

Closes: #1979

@ala-n ala-n added bug Something isn't working needs review The PR is waiting for review labels Oct 12, 2023
@ala-n ala-n added this to the ⚡ESL: 4.13.0 Minor release milestone Oct 12, 2023
@ala-n ala-n requested review from a team October 12, 2023 15:01
@ala-n ala-n requested review from dshovchko, julia-murashko and NastaLeo and removed request for a team October 12, 2023 15:01
@ala-n
Copy link
Collaborator Author

ala-n commented Oct 12, 2023

Needs to be live-tested first
CC: @exadel-inc/esl-core-maintainers

@codeclimate
Copy link

codeclimate bot commented Oct 12, 2023

Code Climate has analyzed commit 58793cd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.9% (-0.1% change).

View more on Code Climate.

@ala-n
Copy link
Collaborator Author

ala-n commented Oct 13, 2023

✅ Live tests passed ✅

@ala-n ala-n merged commit d698d70 into main Oct 16, 2023
7 checks passed
@ala-n ala-n deleted the fix/esl-media-brightcove-fix branch October 16, 2023 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
@ala-n
Copy link
Collaborator Author

ala-n commented Oct 25, 2023

🎉 This PR is included in version 4.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs review The PR is waiting for review released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 in esl-media]: Brightcove Provider some players did not stop after seeking asset to the end
9 participants