-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all concepts and fix CI #199
Conversation
Add concept: abstract-types
Add concept: array-comprehension
Add concept: arrays
Add concept: bit-manipulation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit much to properly review in its entirety, but I've done a cursory review and this looks great. We can always improve things later on.
"prerequisites": [ | ||
"basics", | ||
"strings" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove these prerequisites?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, it was for the CI I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes precisely, it is for the CI.
Closes #187.
I wrote all (and removed some) of the current concepts. This will also fix the CI since the
configlet
requires all conceptauthors
arrays to not be empty.