Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two-bucket: fix implemenation #901

Closed
SleeplessByte opened this issue Dec 24, 2020 · 1 comment · Fixed by #1396
Closed

two-bucket: fix implemenation #901

SleeplessByte opened this issue Dec 24, 2020 · 1 comment · Fixed by #1396
Labels
bug 🐛 Something isn't working good first issue

Comments

@SleeplessByte
Copy link
Member

Don't work on this issue until #895 is merged, or use that PR as a base branch.

When two-bucket was synced, it became evident that some of the tests cases are not passing, at all. Fix the implementation so these test cases pass and replace test.skip with xtest: https://github.com/exercism/javascript/blob/774fb12c4d1f492af9658ece4eec515bf92552e7/exercises/two-bucket/two-bucket.spec.js

@slaymance
Copy link
Contributor

Hey @SleeplessByte I noticed the tests throwing for this exercise and submitted a fix in PR 905. We'll still need another PR to update the example solution since it's failing a couple of the new tests, and running into an infinite loop on a couple of them. With this PR, though, we can at least get the tests working for students.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants