Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Bucket: fix errant tests #905

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Conversation

slaymance
Copy link
Contributor

@slaymance slaymance commented Dec 28, 2020

This PR addresses part of the problem tracked in Issue #901. A couple of test cases were added that were expected to throw yet were invoked immediately in the spec file. This PR wraps those invocations in an anonymous function.

The example solution provided does not pass the test cases as it stands and will need to be addressed in a separate PR. This is an immediate fix so the tests are working for students.

@slaymance slaymance changed the title Two Bucket: fix errant test cases Two Bucket: fix errant tests Dec 28, 2020
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the test.skip changes? They are there on purpose to keep the ci passing!

@SleeplessByte
Copy link
Member

Thanks for this @slaymance . Small oversight on my part 😅

@SleeplessByte SleeplessByte merged commit 83feda2 into exercism:master Dec 28, 2020
@SleeplessByte SleeplessByte added the bug 🐛 Something isn't working label Dec 28, 2020
@slaymance slaymance deleted the fix/two-bucket branch December 28, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants