Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync all exercises #895

Merged
merged 32 commits into from
Dec 24, 2020
Merged

Sync all exercises #895

merged 32 commits into from
Dec 24, 2020

Conversation

SleeplessByte
Copy link
Member

@SleeplessByte SleeplessByte commented Dec 16, 2020

The changes in this PR are as follows:

all-your-base removed some input validation
alphametics added a test that will not complete with naïve solutions
binary-search-tree added various test cases that capture edge cases
binary changed default value to null instead of 0
bob changed one of the tests to clarify what it does
bowling fixed the spelling on several test cases
change changed test names to match canonical data
circular-buffer added various tests that capture edge cases
crypto-square changed stub and test to no longer provide forced way to implement; added various tests that capture edge cases
diamond changed layout so it looks like diamonds
diffie-hellman changed stub to be use-full, changed test cases to be inline with canonical data
dnd-character changed nesting to match canonical data
etl changed test names to match canonical data
flatten-array changed tests and test names to match canonical data; added various tests that capture edge cases
forth changed tests and test names to match canonical data; added various tests that capture edge cases
grade-school re-implemented solution to satisfy new test case
grains added note about bigint in the stub
high-scores changed nesting to match canonical data
isbn-verifier fixed grammar
kindergarten-garden changed example to be idiomatic; added lists of data to stub
linked-list added a track-specific hint about the count method and built-in functions/backing array; added various test cases that catch edge cases
list-ops added a test case to catch an edge case, and remove ambiguity from two cases
luhn added a test case to catch an edge case
minesweeper changed test names to match canonical data
ocr-numbers changed layout so it looks like the numbers
palindrome-products disabled a test case because it takes long to run
prime-factors changed test cases match canonical data
protein-translation added a track-specific hint to indicate we expect runtime-validation; changed test to match canonical-data
proverb: added a track-specific hint to explain the qualifier argument; add a test case to catch an edge case; change test cases to match canonical-data
pythagorean-triplet add a track-specific hint to talk about minFactor and maxFactor; simplify stub (so it no longer leads implementation), and reimplement all tests
queen-attack add track-specific hint to indicate the 2 types of input validation expected, as well as the initial position; update README to remove all ambiguity and add chess notation; re-implement example to be more idiomatic
robot-simulator simplify stub (so it no longer leads implementation), re-implement example and tests to match canonical data
roman-numerals add test case that catches an edge case
series add new test cases that catch edge cases; update existing test cases to match canonical data; adds new forms of input validation
triangle use getter instead of method
two-bucket match canonical data, disable various tests that are failing because our example isn't correct
word-search remove test from tests.toml because it isn't implemented
zipper remote test from tests.toml because it isn't implemented

You might have personal notes you'll want to update, or re-implement the exercise yourself again. The mentor notes have not been updated so they may be slightly out of date. (Help wanted!)

@SleeplessByte SleeplessByte marked this pull request as ready for review December 24, 2020 06:13
@SleeplessByte SleeplessByte requested a review from a team as a code owner December 24, 2020 06:13
@SleeplessByte SleeplessByte requested a review from a team December 24, 2020 06:13
@SleeplessByte SleeplessByte added the sync 🔄 Sync an exercise with the latest version of the problem-spec label Dec 24, 2020
@SleeplessByte SleeplessByte changed the title WIP: Sync all exercises Sync all exercises Dec 24, 2020
@SleeplessByte SleeplessByte merged commit 316084d into master Dec 24, 2020
@SleeplessByte SleeplessByte deleted the chore/sync-tests-toml branch December 24, 2020 14:03
@SleeplessByte
Copy link
Member Author

Thanks for the approves 😌💖.

Big PR, but we're back in sync!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync 🔄 Sync an exercise with the latest version of the problem-spec x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants