-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync all exercises #895
Merged
Merged
Sync all exercises #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2020
SleeplessByte
added
the
sync 🔄
Sync an exercise with the latest version of the problem-spec
label
Dec 24, 2020
ErikSchierboom
approved these changes
Dec 24, 2020
tejasbubane
approved these changes
Dec 24, 2020
Thanks for the approves 😌💖. Big PR, but we're back in sync! |
ErikSchierboom
added
x:size/large
Large amount of work
and removed
reputation/contributed_code/major
labels
Jun 25, 2021
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sync 🔄
Sync an exercise with the latest version of the problem-spec
x:size/large
Large amount of work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are as follows:
•
all-your-base
removed some input validation•
alphametics
added a test that will not complete with naïve solutions•
binary-search-tree
added various test cases that capture edge cases•
binary
changed default value tonull
instead of0
•
bob
changed one of the tests to clarify what it does•
bowling
fixed the spelling on several test cases•
change
changed test names to match canonical data•
circular-buffer
added various tests that capture edge cases•
crypto-square
changed stub and test to no longer provide forced way to implement; added various tests that capture edge cases•
diamond
changed layout so it looks like diamonds•
diffie-hellman
changed stub to be use-full, changed test cases to be inline with canonical data•
dnd-character
changed nesting to match canonical data•
etl
changed test names to match canonical data•
flatten-array
changed tests and test names to match canonical data; added various tests that capture edge cases•
forth
changed tests and test names to match canonical data; added various tests that capture edge cases•
grade-school
re-implemented solution to satisfy new test case•
grains
added note about bigint in the stub•
high-scores
changed nesting to match canonical data•
isbn-verifier
fixed grammar•
kindergarten-garden
changed example to be idiomatic; added lists of data to stub•
linked-list
added a track-specific hint about thecount
method and built-in functions/backing array; added various test cases that catch edge cases•
list-ops
added a test case to catch an edge case, and remove ambiguity from two cases•
luhn
added a test case to catch an edge case•
minesweeper
changed test names to match canonical data•
ocr-numbers
changed layout so it looks like the numbers•
palindrome-products
disabled a test case because it takes long to run•
prime-factors
changed test cases match canonical data•
protein-translation
added a track-specific hint to indicate we expectruntime-validation
; changed test to match canonical-data•
proverb
: added a track-specific hint to explain thequalifier
argument; add a test case to catch an edge case; change test cases to match canonical-data•
pythagorean-triplet
add a track-specific hint to talk aboutminFactor
andmaxFactor
; simplify stub (so it no longer leads implementation), and reimplement all tests•
queen-attack
add track-specific hint to indicate the 2 types of input validation expected, as well as the initial position; update README to remove all ambiguity and add chess notation; re-implement example to be more idiomatic•
robot-simulator
simplify stub (so it no longer leads implementation), re-implement example and tests to match canonical data•
roman-numerals
add test case that catches an edge case•
series
add new test cases that catch edge cases; update existing test cases to match canonical data; adds new forms of input validation•
triangle
use getter instead of method•
two-bucket
match canonical data, disable various tests that are failing because our example isn't correct•
word-search
remove test fromtests.toml
because it isn't implemented•
zipper
remote test fromtests.toml
because it isn't implementedYou might have personal notes you'll want to update, or re-implement the exercise yourself again. The mentor notes have not been updated so they may be slightly out of date. (Help wanted!)