Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pangram: update tests to version 1.3.0 #1018

Closed
N-Parsons opened this issue Oct 25, 2017 · 0 comments
Closed

pangram: update tests to version 1.3.0 #1018

N-Parsons opened this issue Oct 25, 2017 · 0 comments

Comments

@N-Parsons
Copy link
Contributor

As identified in #784, some of the exercise test-suites are out-of-date, pangram is one of them. It would therefore be really helpful for people to go through and update the test suite to match the canonical data.

Tests should typically be ordered according to their order in the canonical data, since this makes it easier to check and update them in future. If you think that there's a better order, please let us know your reasoning in your PR.

If there are some additional tests that currently exist in this track but which aren't in the canonical data, these can be kept if you think that they are useful. They should be placed at the bottom of the test cases, and it would also be super-helpful if you could add a comment before them saying # Additional tests for this track to make it clear that they aren't part of the canonical data.

The version string should be placed just before the first test class and followed by a blank line. For this exercise, the version string is:

# Tests adapted from `problem-specifications//canonical-data.json` @ v1.3.0

Test suite: exercism/python/exercises/pangram/pangram_test.py
Canonical data: exercism/problem-specifications/exercises/pangram/canonical-data.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants