Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pangram: update tests to version 1.3.0 #1078

Closed
wants to merge 1 commit into from
Closed

pangram: update tests to version 1.3.0 #1078

wants to merge 1 commit into from

Conversation

kishan3
Copy link

@kishan3 kishan3 commented Oct 30, 2017

Resolves #1018

@cmccandless
Copy link
Contributor

@kishan3 This is a duplicate of #1039

@N-Parsons
Copy link
Contributor

Looks like the last test needs updating - the canonical data is "input": "the quick brown fox jumps over with lazy FX", "expected": false

@kishan3
Copy link
Author

kishan3 commented Oct 30, 2017

@cmccandless ah ok.. should this be closed?

@kishan3
Copy link
Author

kishan3 commented Oct 30, 2017

@N-Parsons sure will make changes if this is going to merge.

@cmccandless
Copy link
Contributor

@kishan3 Yes, I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kishan3 @cmccandless @N-Parsons