-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTING.md] Enhance TESTING docs #2611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to put this together @J08K !
The testing document seems to cover things nicely enough, though that is coming from the perspective of someone having already installed pytest and likely not really leveraging all it has to offer (I still just hit the play button in PyCharm to run the tests).
As far as tools go I wish I had started using tools like PyCharm or VS Code earlier than I had so it's great to see a page like this where new users might see it =D
Personally I'm a huge fan of PyCharm, but after some thought and in consideration of the context I'm happy with seeing VS Code given a little more preference in the hierarchy, given that it's lighter and more language agnostic than the full blown IDEs. I think that makes it more in line with Exercism's promotion of learning multiple languages while at the same time checking all the boxes for general use with Exercism (linter, debugging, formatting).
I think it might be worth mentioning in the description that since it's a code editor as opposed to a full blown IDE it takes less system resources and loads faster while still having all the features needed to enjoy Exercism:
"Visual studio code (VS Code) is a code editor created by Microsoft. It is not specialized to work for a specific programming language, but to be an editor that can do everything. You can extend the editor using extensions, but it comes with some great extensions as well. While VS Code may not be as feature rich as a language specific IDE it has everything needed to enjoy Exercism to its fullest, tends to be less complicated, takes up less system resources, and due to its smaller size usually launches faster too."
Or maybe under the header for IDEs and code editors mentioning the difference (more features, bigger and sometimes slower vs only the features needed, smaller and oftentimes faster)?
Hey, @squeakyboots thank you for your feedback! I could add a piece about the difference between an Editor and an IDE, but the file is not meant for students to decide what environment they are gonna use. It is about extending the environment they already have. |
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot! 🌟 @J08K -- this is an excellent rundown, and a great base to build on. Thank you so much for taking this on! I've left a few comments. Most are suggestions (except the venv
one). Let me know if you have questions or issues. Otherwise, change, merge and celebrate! 🎉 🌈
Note to other reviewers: Please refrain from merging this. @J08K should take one more look before doing the honors. Thanks! |
Co-authored-by: BethanyG <[email protected]>
Co-authored-by: BethanyG <[email protected]>
Co-authored-by: BethanyG <[email protected]>
Co-authored-by: BethanyG <[email protected]>
Co-authored-by: BethanyG <[email protected]>
Co-authored-by: BethanyG <[email protected]>
👏 🚀 Great job! |
Heya people,
This is what I've been working on till now. It was quite a lot of writing, so please take your time in reading it. I would love to know what you think of it. Currently the images are not properly showing up in the markdown files, because they are not on GitHub yet. Will fix that before merging the PR.
This will resolve #2560.
Currently what's done:
Adding to path
InTESTS.md
I wanted to add a part about adding thepytest
module to path, because this does not automatically happen on a lot of python installations. I am now wondering if this is really necessary, so I'd like to ask the community here. Editing your environment variables is not tricky, but if you do screw it up it has bad repercussions. Which is both a valid point against and supporting having good instructions for how to do it. My other thought was if it was really necessary for us to add it in. People can otherwise look it up themselves.Let me know what you think.
Ended up only adding the Windows tutorial for now, most of the time it seems work on Linux and Mac out-of-the-box. Not a priority.
The PR is not done yet, but I just wanted to get some feedback first before finishing it entirely.
Thanks!