-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTING.md] Enhance TESTING docs #2611
Merged
Merged
Changes from 12 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
81a7c22
Update TESTS.md
J08K 6548ec9
Update TESTS.md
J08K 2b51829
Update TESTS.md
J08K d447645
Start of TOOLS.md
J08K 60b84f3
Finished writing VS Code part
J08K 1a72ef0
Added Pycharm docs & relative img links
J08K 7b87a4f
Update TOOLS.md
J08K 1021bb8
Added Spyder Docs
J08K 3d66c2b
Added VENV docs
J08K 09b1813
Added conda environments docs
J08K 9c1d1a9
Wrote Windows tutorial for adding to path
J08K 3c18af3
Improved shared test file and added disclaimer to TOOLS.md
J08K 5ac3fa2
Added docs for JupyterLab and Sublime Text
J08K ae2de41
Added Virtualenvwrapper piece.
J08K b8c8a9a
Cleaned up.
J08K 553b6d7
Updated image paths
J08K 68eca1f
Fixed Images x2
J08K 430bac3
Images have absolute path
J08K a433864
Update docs/TESTS.md
J08K d2612d9
Update docs/TESTS.md
J08K 584fd07
Update docs/TESTS.md
J08K 2e15fac
Update docs/TESTS.md
J08K 782c5df
Update docs/TESTS.md
J08K d00a764
Update docs/TESTS.md
J08K 5400ae3
Update docs/TOOLS.md
J08K 3e9b506
Update docs/TOOLS.md
J08K fcc43f9
Update docs/TESTS.md
J08K 7dc6c9c
Update docs/TOOLS.md
J08K 15ae0db
Update docs/TOOLS.md
J08K d6d57f5
Update exercises/shared/.docs/tests.md
J08K d770ab8
Update exercises/shared/.docs/tests.md
J08K 994ad50
Fixed capitalization
J08K f4224c0
Update docs/TOOLS.md
J08K 75b0ad6
Fixed language
J08K cb990e3
Update docs/TOOLS.md
J08K 092a25b
Update docs/TOOLS.md
J08K 95b28cc
Update docs/TOOLS.md
J08K 1ff0be9
Update docs/TESTS.md
J08K 6c1328c
Update docs/TOOLS.md
J08K 170d298
Update docs/TOOLS.md
J08K 92c6c4e
Update docs/TESTS.md
J08K 85ae17e
Update docs/TESTS.md
J08K f053a22
Update docs/TESTS.md
J08K b8ad4b5
Update docs/TOOLS.md
J08K e6b8588
Update docs/TESTS.md
J08K c913f75
Added pytest.ini docs
J08K 81abb80
Update docs/TESTS.md
J08K 3684cdd
Update docs/TESTS.md
J08K 3d66a5c
Update docs/TESTS.md
J08K 8f2692b
Update docs/TOOLS.md
J08K 822a54b
Apply suggestions from code review
J08K 0ee4359
Update docs/TOOLS.md
J08K 0c53083
Update docs/TOOLS.md
J08K cde80ca
Update docs/TOOLS.md
J08K f2ea08d
Update docs/TOOLS.md
J08K 1db4ce9
Update headers and links
J08K File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,115 +1,196 @@ | ||
# Tests | ||
|
||
## Tools to install | ||
TODO: Change links to constant URL, not relative. | ||
|
||
We recommend you install [pytest](http://pytest.org/en/latest/) with the following plugins: | ||
1. [Pytest](#pytest) | ||
- [Installation](#installing-pytest) | ||
- [Virtual environments](#virtual-environments) | ||
- [Running the tests](#running-the-tests) | ||
- [Failing tests](#failures) | ||
- [Extra arguments](#extra-arguments) | ||
- [Stop test after first failure](#stop-after-first-failure-[-x]) | ||
- [Failed Tests First](#failed-tests-first-[--ff]) | ||
- [Recommended setup](#recommended-workflow) | ||
- [Python Debugger in Pytest](#python-debugger) | ||
2. [Tools for your IDE](#extending-your-ide) | ||
3. [Additional Information](#additional-information) | ||
- [Adding python scripts to path](#adding-to-path) TODO | ||
|
||
- [pytest-cache](http://pythonhosted.org/pytest-cache/) | ||
- [pytest-subtests](https://github.com/pytest-dev/pytest-subtests) | ||
- [pytest-pylint](https://github.com/carsongee/pytest-pylint) | ||
|
||
The PyTest [Getting Started Guide](https://docs.pytest.org/en/latest/getting-started.html) has quick general instructions, although they do not cover installing the plugins. | ||
Continue reading below for plugin installation. | ||
|
||
We also recommend [pylint](https://pylint.pycqa.org/en/latest/user_guide/), as it is part of our automated feedback on the website, and can be a very useful (if noisy!) code analysis tool. | ||
--- | ||
|
||
Pylint can be a bit much, so this [tutorial](https://pylint.pycqa.org/en/latest/tutorial.html) can be helpful for getting started, as can this overview of [Code Quality: Tools and Best Practices](https://realpython.com/python-code-quality/) from Real Python. | ||
## Pytest | ||
|
||
Finally, [this site](https://pycodequ.al/docs/pylint-messages.html) is a great place to look up more human-readable descriptions of Pylint linting messages. | ||
_Official Pytest documentation can be found on the [Pytest Wiki](https://pytest.org/en/latest/) page._ | ||
|
||
Pytest let's you test your solutions using our provided tests, it is what we use to validate your solutions on the website. | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
### Installing `pytest` | ||
### Installing Pytest | ||
|
||
To install `pytest`, run the following command in the environment (_active `venv`, `conda env`, `docker container`, `vm` or other project space with Python 3.8 installed_): | ||
Pytest can be installed and updated using the built-in Python utility `pip`. | ||
|
||
```bash | ||
pip3 install pytest pytest-cache pytest-subtests pytest-pylint | ||
#### Windows | ||
|
||
```powershell | ||
PS C:\Users\foobar> python3 -m pip install pytest pytest-cache pytest-subtests pytest-pylint | ||
Successfully installed pytest-6.2.5 ... | ||
``` | ||
|
||
If you get a `command not found` response from your system, you can find a | ||
tutorial on how to install `pip` | ||
[here](https://pip.pypa.io/en/stable/installing/). | ||
#### Linux / MacOS | ||
|
||
Once the installation has completed, you can check what the default version of `pytest` is by running the following: | ||
```bash | ||
$ sudo python3 -m pip install pytest pytest-cache pytest-subtests pytest-pylint | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Successfully installed pytest-6.2.5 ... | ||
|
||
``` | ||
|
||
To check if the installation was succesful: | ||
|
||
```bash | ||
pytest --version | ||
$ python3 -m pytest --version | ||
pytest 6.2.5 | ||
``` | ||
|
||
## Testing | ||
If you do not want to precede every command with `python3 -m` please refer to [adding to PATH](#adding-to-path) at the end of this document. | ||
|
||
#### Virtual environments | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
### Run All Tests for an Exercise | ||
*For more information about virtual environments please refer to the [TOOLS](.\TOOLS.md) file.* | ||
|
||
To run all tests for a specific exercise (_we will take the `bob.py` exercise as | ||
an example here_), navigate to the directory where that exercise has been | ||
downloaded and run the following in the terminal: | ||
When installing Pytest or any other module(s), make sure that you have [activated your environment](.\TOOLS.md#activating-your-environment). After which you can run: | ||
|
||
```bash | ||
pytest bob_test.py | ||
$ pip install pytest pytest-cache pytest-subtests pytest-pylint | ||
Successfully installed pytest-6.2.5 ... | ||
``` | ||
|
||
**Note:** To run the tests you need to pass the name of the testsuite file to | ||
`pytest` (_generally, this will be the file ending with `_test.py`_), **NOT** the file that was | ||
created to solve the exercsim problem (which is the _solution implementation_). | ||
`PyTest` needs the test definitions in the `_test.py` file in order to know how to call, run, and exercise the _solution implementation_ code. | ||
Since there are no test cases defined in the _solution implementation_, `pytest` will just return a positive result, specifying that it found and ran zero tests. Like this: | ||
### Running the tests | ||
|
||
To run your test, go to the folder where the exercise is stored using `cd` in your terminal (_replace `{exercise-folder-location}` below with the path_). | ||
|
||
```bash | ||
$ cd {exercise-folder-location} | ||
``` | ||
|
||
The file you'll want always ends with `_test.py`, this file contains the tests for your solution, and are the same tests run on the website. Now run the following command in your terminal, replacing `{exercise_test.py}` with the location/name of the the testing file: | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
```bash | ||
$ python3 -m pytest {exercise_test.py} | ||
==================== 7 passed in 0.08s ==================== | ||
``` | ||
============================= bob.py ============================== | ||
|
||
--------------------------------------------------------------------- | ||
#### Failures | ||
|
||
Ran 0 tests in 0.000s | ||
When your code returns an incorrect or unexpected value, pytest returns all the failed tests and the returned and expected values of each. Look at the following failed test file: | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
OK | ||
```bash | ||
$ python3 -m pytest {exercise_test.py} | ||
=================== FAILURES ==================== | ||
______________ name_of_failed_test ______________ | ||
# Test code inside of {exercise_test.py} that failed. | ||
... | ||
E TypeOfError: ReturnedValue != ExpectedValue | ||
|
||
exercise_test.py:{line_of_failed_test}: TypeOfError | ||
============ short test summary info ============ | ||
FAILED exercise_test.py::ExerciseTest::name_of_failed_test | ||
========== 1 failed, 2 passed in 0.13s ========== | ||
``` | ||
|
||
### Extra arguments | ||
|
||
### More `pytest` Examples | ||
If you really want to be specific about what Pytest returns on your screen, here are some handy arguments that will make Pytest return a more specific dataset. | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Below are some additional examples and details for getting up and running quickly with Pytest. | ||
[How to invoke pytest](https://docs.pytest.org/en/latest/how-to/usage.html#usage) and [pytest command-line flags](https://docs.pytest.org/en/latest/reference/reference.html#command-line-flags) offer full details on all of pytests run options. | ||
#### Stop After First Failure [`-x`] | ||
|
||
Running the `pytest -x {exercise_test.py}` command, will run the tests like normal, but will stop the tests when it encounters a failed test. This will help when you want to debug a single failure at a time. | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
#### Stop After First Failure | ||
The above will run all the tests, whether they fail or not. If you'd rather stop | ||
the process and exit on the first failure, run: | ||
```bash | ||
$ python -m pytest -x example_test.py | ||
=================== FAILURES ==================== | ||
_______________ example_test_foo ________________ | ||
... | ||
... | ||
============ short test summary info ============ | ||
FAILED example_test.py::ExampleTest::example_test_foo | ||
!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!! | ||
========== 1 failed, 5 passed in 0.28s ========== | ||
``` | ||
|
||
#### Failed Tests First [`--ff`] | ||
|
||
`pytest-cache` remembers which tests failed last time you ran `pytest`, running `pytest --ff {exercise_test.py}` will run those previously failed tests first, then it will continue with the rest of the tests. This might speed up your testing if you are making a lot of smaller fixes. | ||
|
||
```bash | ||
pytest -x bob_test.py | ||
$ python -m pytest --ff bob_test.py | ||
``` | ||
|
||
#### Failed Tests First | ||
#### Recommended Workflow | ||
|
||
We recommend using the following commands to make your debugging easier and (possibly) faster: | ||
|
||
`pytest-cache` remembers which tests failed, and can run those tests first. | ||
First change your working directory to the directory of the exercise you want to test: | ||
|
||
```bash | ||
pytest --ff bob_test.py | ||
cd path/to/exercise | ||
``` | ||
|
||
#### Running All Tests for All Exercises | ||
Then, run the tests together with the previously explained arguments `-x` and`--ff`: | ||
|
||
```bash | ||
cd exercism/python/ | ||
pytest | ||
pytest -x -ff bob_test.py | ||
``` | ||
|
||
## Recommended Workflow | ||
This will test your solution. When `pytest` encounters a failed test, the program will stop and tell you which test failed. When you run the test again, `pytest` will first test that failed test, then continue with the rest. | ||
|
||
Try this command while working on exercises: | ||
#### Python Debugger | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
If you want to truly debug like a pro, use the `--pdb` argument after the `pytest` command. | ||
|
||
```bash | ||
cd exercism/python/bob | ||
pytest -x --ff bob_test.py | ||
$ python3 -m pytest --pdb bob_test.py | ||
``` | ||
|
||
## PDB | ||
When a test fails it allows you to look at variables and how your code responds. If you want to learn how to really use `PDB` module, have a look at the [Python Docs](https://docs.python.org/3/library/pdb.html#module-pdb) or [this](https://realpython.com/python-debugging-pdb/) Real Python article. | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Extending your IDE | ||
|
||
If you'd like to extend your IDE with some tools that will help you with testing/improving your code, check [this]() page. We go into multiple IDEs and editors and some useful extensions. | ||
|
||
## Additional information | ||
|
||
### Adding to PATH | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Typing pdb on the command line will drop you into the python debugger when a test fails. | ||
To learn how to usepdb, check out the | ||
[documentation](https://docs.python.org/3/library/pdb.html#debugger-commands). | ||
**Note:** If you are running a [virtual environment](.\TOOLS.md) you do not need to *add to path* as it should work fine. | ||
|
||
Preceding every module you want to run with `python3 -m` might get a little annoying. You can add the `Scripts` folder of your Python installation to your path. If you do not know where you have installed Python, run the following command in your terminal: | ||
J08K marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
```bash | ||
pytest --pdb bob_test.py | ||
$ python3 -c "import os, sys; print(os.path.dirname(sys.executable))" | ||
{python_directory} | ||
``` | ||
|
||
The *returned* directory is where your Python version is installed, in this tutorial it is referred to as `{python_directory}`. | ||
|
||
#### Windows | ||
|
||
Click the `Windows Start` button and lookup *Edit the system environment variables* and press enter. Next press, `Environment Variables...`: | ||
|
||
![Press the blue button, lol](.\img\Windows-SystemProperties.png) | ||
|
||
Then find the `Path` variable in your *User variables*, select it, and click `Edit...`: | ||
|
||
![Selecting the path variable](.\img\Windows-EnvironmentVariables.png) | ||
|
||
Then add a new line, as shown in the picture, replacing `{python_directory}` with your Python installation's directory: | ||
|
||
![Add python to path](.\img\Windows-AddPythonPath.png) | ||
|
||
#### MacOS X | ||
|
||
TODO | ||
|
||
#### Linux | ||
|
||
TODO |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we actually need to put these Pytest plugins somewhere (and how to install them). We actually need the subtest and cache ones. The pylint one is not needed right now, but will be needed once we update the implementation tests.