-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android][ios] Upgrade react-native-reanimated to 2.3.1 #15574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this pr does not introduce many native changes. for sdk 44 release, i'm going to merge this pr and have a post-review. |
tsapeta
reviewed
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for upgrading it! 👍
Kudo
added a commit
that referenced
this pull request
Dec 15, 2021
# Why upgrade react-native-reanimated to 2.3.1 for sdk 44 release # How - `et uvm -m react-native-reanimated -c "2.3.1"` - revert reanimated autolinking exclusion for bare-expo and bare-sandbox - `et add-sdk -p ios -s 44.0.0 -v react-native-reanimated` - `et remove-sdk -p android -s 44.0.0 && et add-sdk -p android -s 44.0.0` and pick reanimated changes. # Test Plan android versioned expo go + gesture handler NCL ios versioned expo go + gesture handler NCL
DominickVale
pushed a commit
to DominickVale/expo
that referenced
this pull request
Dec 15, 2021
# Why upgrade react-native-reanimated to 2.3.1 for sdk 44 release # How - `et uvm -m react-native-reanimated -c "2.3.1"` - revert reanimated autolinking exclusion for bare-expo and bare-sandbox - `et add-sdk -p ios -s 44.0.0 -v react-native-reanimated` - `et remove-sdk -p android -s 44.0.0 && et add-sdk -p android -s 44.0.0` and pick reanimated changes. # Test Plan android versioned expo go + gesture handler NCL ios versioned expo go + gesture handler NCL
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why upgrade react-native-reanimated to 2.3.1 for sdk 44 release # How - `et uvm -m react-native-reanimated -c "2.3.1"` - revert reanimated autolinking exclusion for bare-expo and bare-sandbox - `et add-sdk -p ios -s 44.0.0 -v react-native-reanimated` - `et remove-sdk -p android -s 44.0.0 && et add-sdk -p android -s 44.0.0` and pick reanimated changes. # Test Plan android versioned expo go + gesture handler NCL ios versioned expo go + gesture handler NCL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
upgrade react-native-reanimated to 2.3.1 for sdk 44 release
How
et uvm -m react-native-reanimated -c "2.3.1"
et add-sdk -p ios -s 44.0.0 -v react-native-reanimated
et remove-sdk -p android -s 44.0.0 && et add-sdk -p android -s 44.0.0
and pick reanimated changes.Test Plan
android versioned expo go + gesture handler NCL
ios versioned expo go + gesture handler NCL
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).