Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use option object for serveIndex[type] #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

coolaj86
Copy link

@coolaj86 coolaj86 commented Aug 13, 2018

PR Dependencies:

Description

Lots of the PRs involve adding options on how to change the view.

As part of moving towards having the ability to consistent output between the 3 templates (plain, json, and html), and the potential to have theme modules in the future, it seems to make sense to move towards a viewOptions object that can be passed to template functions.

serveIndex[mediaType[type]](req, res, directory, nodes, next, viewOptions)

instead of ever growing

serveIndex[mediaType[type]](req, res, directory, nodes, next, showUp, icons, path, view, template, stylesheet, twentyOneThing, twentyTwoThing, orangeRedThing, tourquiseBlueThing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants