Skip to content

Commit

Permalink
[stable/external-dns] Addded a parameter for supporting --aws-assume-…
Browse files Browse the repository at this point in the history
…role flag in external-dns (helm#12164)

Signed-off-by: Enis Soztutar <[email protected]>
  • Loading branch information
enis authored and eyenx committed May 28, 2019
1 parent 30cf5be commit 62703ea
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion stable/external-dns/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: |
Configure external DNS servers (AWS Route53, Google CloudDNS and others)
for Kubernetes Ingresses and Services
name: external-dns
version: 1.7.5
version: 1.7.6
appVersion: 0.5.13
home: https://github.com/kubernetes-incubator/external-dns
sources:
Expand Down
1 change: 1 addition & 0 deletions stable/external-dns/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ The following table lists the configurable parameters of the external-dns chart
| ---------------------------------- | -------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------- |
| `annotationFilter` | Filter sources managed by external-dns via annotation using label selector semantics (default: all sources) (optional). | `""` |
| `aws.accessKey` | set in `~/.aws/credentials` mounted through secret (optional). | `""` |
| `aws.assumeRoleArn` | Assume role by specifying --aws-assume-role to the external-dns daemon. | `""` |
| `aws.secretKey` | set in `~/.aws/credentials` mounted through secret (optional). | `""` |
| `aws.credentialsPath` | determine `mountPath` for `credentials` secret, defaults to `nobody` USER home path `/.aws` (optional). | `"/.aws"` |
| `aws.region` | `AWS_DEFAULT_REGION` to set in the environment (optional). | `us-east-1` |
Expand Down
3 changes: 3 additions & 0 deletions stable/external-dns/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ spec:
{{ if .Values.dryRun }}
- --dry-run
{{- end }}
{{ if .Values.aws.assumeRoleArn }}
- --aws-assume-role={{ .Values.aws.assumeRoleArn }}
{{- end }}
{{- range $key, $value := .Values.extraArgs }}
{{- if $value }}
- --{{ $key }}={{ $value }}
Expand Down
1 change: 1 addition & 0 deletions stable/external-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ aws:
region: "us-east-1"
# Filter for zones of this type (optional, options: public, private)
zoneType: ""
assumeRoleArn: ""

azure:
# If you don't specify a secret to load azure.json from, you will get the host's /etc/kubernetes/azure.json
Expand Down

0 comments on commit 62703ea

Please sign in to comment.