Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30263: replaces deprecated functions #173

Merged
merged 1 commit into from
Mar 28, 2019
Merged

EZP-30263: replaces deprecated functions #173

merged 1 commit into from
Mar 28, 2019

Conversation

pawbuj
Copy link
Contributor

@pawbuj pawbuj commented Mar 28, 2019 •
edited
Loading

@pawbuj pawbuj requested review from dew326 and sunpietro March 28, 2019 08:57
@pawbuj pawbuj self-assigned this Mar 28, 2019
@pawbuj pawbuj mentioned this pull request Mar 28, 2019
Merged
2 tasks
dew326
dew326 requested changes Mar 28, 2019
View reviewed changes
src/modules/sub-items/components/table-view/table.view.item.component.js
@@ -154,11 +154,11 @@ export default class TableViewItemComponent extends PureComponent {
}

const { content } = this.props;
const { formatShortDateWithTimezone } = window.eZ.helpers.timezone;
const { formatShortDateTime } = window.eZ.helpers.timezone;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the date was converted to preferred time zone. I think the helper should automatically convert to preferred timezone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch
ezsystems/ezplatform-admin-ui@bd5e898

m-tyrala
m-tyrala approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@m-tyrala m-tyrala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved (automated tests passed locally, when all PRs were together)

@lserwatka lserwatka merged commit 99411f9 into master Mar 28, 2019
@lserwatka lserwatka deleted the EZP-30263 branch March 28, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@m-tyrala m-tyrala m-tyrala approved these changes

@sunpietro sunpietro Awaiting requested review from sunpietro

Assignees

@pawbuj pawbuj

Labels
Improvement QA approved Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pawbuj @tischsoic @dew326 @m-tyrala @lserwatka