EZP-30263: User date format don't apply to date fields in content item update and preview #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawbuj
force-pushed
the
EZP-30263
branch
2 times, most recently
from
6e6afcd
to
201deca
Compare
2 tasks
mikadamczyk
approved these changes
Mar 20, 2019
| ezplatform.user.settings.short_time_format.formatter: | ||
| lazy: true | ||
| factory: 'EzSystems\EzPlatformUser\UserSetting\DateTimeFormat\ShortDateFormatterFactory:getFormatter' | ||
| class: 'EzSystems\EzPlatformUser\UserSetting\DateTimeFormat\Formatter' |
There was a problem hiding this comment.
missing empty line at the end of the file
| } | ||
|
|
||
| return $this->fullDateTimeFormatter->format($date); | ||
| return $formatter->format($date); |
There was a problem hiding this comment.
$date is used as an argument in the format() method. We should probably check if it is instanceof DateTime. We can not pass here for example string.
webhdx
approved these changes
Mar 20, 2019
adamwojs
approved these changes
Mar 20, 2019
adamwojs
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more date and time filters to twig
Warning, it is just one part, will be another pull request to admin-ui
Checklist:
$ composer fix-cs)