Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WatchConnectionManager warning log provides little information #3001

Closed
shawkins opened this issue Apr 15, 2021 · 2 comments
Closed

WatchConnectionManager warning log provides little information #3001

shawkins opened this issue Apr 15, 2021 · 2 comments
Assignees
@shawkins
Milestone
5.5.0

Comments

@shawkins
Copy link
Contributor

We see occurrences of the following:

2021-04-14 03:49:17,302 WARN  [io.fab.kub.cli.dsl.int.WatchConnectionManager] (OkHttp https://172.30.0.1/...) Exec Failure: java.io.EOFException
	at okio.RealBufferedSource.require(RealBufferedSource.java:65)
	at okio.RealBufferedSource.readByte(RealBufferedSource.java:78)
	at okhttp3.internal.ws.WebSocketReader.readHeader(WebSocketReader.java:117)
	at okhttp3.internal.ws.WebSocketReader.processNextFrame(WebSocketReader.java:101)
	at okhttp3.internal.ws.RealWebSocket.loopReader(RealWebSocket.java:273)
	at okhttp3.internal.ws.RealWebSocket$1.onResponse(RealWebSocket.java:209)
	at okhttp3.RealCall$AsyncCall.execute(RealCall.java:174)
	at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

But that conveys very little information. Presumably this can happen if the other side drops the websocket connection. Could the message be improved or the stacktrace omitted for EOFExceptions?
@manusa
Copy link
Member

manusa commented May 5, 2021

Relates to #2993

shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
c360a08 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
6b339a0 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
68d2716 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
6aa9daa 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
fe0815b 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 2, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
5fe377a 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 2, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
22d7041 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 2, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
3ddf258 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 3, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
5c6ef3e 
…ions and closure

this localizes the state of a websocket to the listener and removes the
runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 3, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
19c2219 
…ions and closure

this localizes the state of a websocket to the listener and removes the
runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 3, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
a635096 
…ions and closure

this removes the runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
@shawkins shawkins self-assigned this Jun 5, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 8, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
93da37b 
…ions and closure

this removes the runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 8, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
7da7e59 
…ions and closure

this removes the runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
manusa pushed a commit that referenced this issue Jun 9, 2021
@shawkins @manusa
fixing #3001 #3186 over logging of websocket exceptions and closure
c8879af 
this removes the runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
@shawkins
Copy link
Contributor Author

shawkins commented Jun 9, 2021

Closed via #3197

@shawkins shawkins closed this as completed Jun 9, 2021
@manusa manusa added this to the 5.5.0 milestone Jun 10, 2021
@shawkins shawkins mentioned this issue Jun 16, 2021
Closed
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 16, 2021
@shawkins
related to fabric8io#3001, ignoring reconnect when closed should not …
6ddbaeb 
…be a warn
@shawkins shawkins mentioned this issue Jun 16, 2021
Merged
11 tasks
manusa pushed a commit that referenced this issue Jun 21, 2021
@shawkins @manusa
related to #3001, ignoring reconnect when closed should not be a warn
223b36a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
5.5.0
Development

No branches or pull requests
2 participants
@manusa @shawkins