Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old WebSockets are not explicitly closed on HTTP_GONE #3186

Closed
shawkins opened this issue May 27, 2021 · 1 comment
Closed

Old WebSockets are not explicitly closed on HTTP_GONE #3186

shawkins opened this issue May 27, 2021 · 1 comment
Assignees
@shawkins
Milestone
5.5.0

Comments

@shawkins
Copy link
Contributor

The expectation in the code seems to be that on HTTP_GONE the api server will kill the websocket connection:

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/WatchConnectionManager.java

Line 100 in 74cc63d

webSocketRef.set(null); // lose the ref: closing in close() would only generate a Broken pipe

However we have a log / threaddump confirming a lingering websocket 2 hours after that event. Is there a reference for that expected behavior and/or could there be some logic to quietly close the websocket at this point?

cc @manusa @rohanKanojia
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
c360a08 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
6b339a0 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
68d2716 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
6aa9daa 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 31, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
fe0815b 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 2, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
5fe377a 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 2, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
22d7041 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 2, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
3ddf258 
…ions and closure

this localizes the state of a websocket to the listener, rather than the
runner to have a clearer lifecycle.

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 3, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
5c6ef3e 
…ions and closure

this localizes the state of a websocket to the listener and removes the
runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 3, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
19c2219 
…ions and closure

this localizes the state of a websocket to the listener and removes the
runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
@shawkins shawkins self-assigned this Jun 3, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 3, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
a635096 
…ions and closure

this removes the runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 8, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
93da37b 
…ions and closure

this removes the runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 8, 2021
@shawkins
fixing fabric8io#3001 fabric8io#3186 over logging of websocket except…
7da7e59 
…ions and closure

this removes the runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
manusa pushed a commit that referenced this issue Jun 9, 2021
@shawkins @manusa
fixing #3001 #3186 over logging of websocket exceptions and closure
c8879af 
this removes the runner abstraction

it also replaces the use of BlockingQueue with CompletableFuture.
@shawkins
Copy link
Contributor Author

shawkins commented Jun 9, 2021

Closed via #3197

@shawkins shawkins closed this as completed Jun 9, 2021
@manusa manusa added this to the 5.5.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
5.5.0
Development

No branches or pull requests
2 participants
@manusa @shawkins