-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DefaultController#processLoop interrupt should not display stackTrace #3015
Comments
@akram : Thanks a lot for reporting this. I think it makes sense. Would you like to submit a PR for this? |
I was about to open an issue about that. I even think that for a such log, it should be at the debug level. |
Do you mean to refactor interrupted exceptions in informers package or across kuberenetes-client? |
I am willing to do the review the entire project, I found 41 catch. But I am just suggesting to change some InterruptedException log, not every log I found. I saw some cases where an error log or a warn was justifed. |
oh, okay. Thanks a lot for clarification! Shall I assign this issue to you? |
You can, no objection. |
…minal terminating behavior
Hey really thank you @hibnico and @rohanKanojia , I had a branch locally with that single fix, I would have done the PR, but @hibnico seems to have done better in #3021 |
…minal terminating behavior
When stopping an informer, the DefaultController#processLoop displays the interruption stacktrace.
This is annoying as it makes think that this is an unexpected behaviour.
It should be replaced by:
The text was updated successfully, but these errors were encountered: