Fix #3015: Log InterruptedException in debug when it is a nominal terminating behavior #3021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here is a review of the catch of the InterruptedException and their logs. I have done more than looking to the core code of the client. These suggestions are up for debate, and thus can be reverted in this PR.
So, every log about an nominal InterruptedException is now in debug, with the message of the exception but not the stack trace.
Special cases on some catch that I found:
BaseOperation#createOrReplace
: there used to be aprintStackTrace
. I tried to improve it by a log and propagate the status of the interrupted thread. But considering the case here, maybe there is more to do.CreateOrReplaceHelper#createOrReplaceItem
: same considerationsCHEATSHEET.md
: I have found these weird piece of catch without thetry
keyword. I took the liberty to juste remove it. Javac will raise an error about the InterruptedException to handle, I see no need to do it explicitely here in the cheat sheet.A side note on
PortForwardEquivalent
example. I don't see how thecountDownLatch
is usefull there,countDown
is never called on it.Fix #3015
Type of change
test, version modification, documentation, etc.)
Checklist