Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky DefaultSharedIndexInformerTest in kubernetes-tests/ #3036

Closed
rohanKanojia opened this issue Apr 22, 2021 · 1 comment · Fixed by #3112
Closed

Fix flaky DefaultSharedIndexInformerTest in kubernetes-tests/ #3036

rohanKanojia opened this issue Apr 22, 2021 · 1 comment · Fixed by #3112
Assignees
@rohanKanojia
Labels
component/kubernetes-tests Deals with the kubernetes-tests

Comments

@rohanKanojia
Copy link
Member

I'm seeing a lot of failures of https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/DefaultSharedIndexInformerTest.java on CI

Error:  Failures: 
Error:    DefaultSharedIndexInformerTest.testAllNamespacedInformer:224 expected:<100[1]> but was:<100[0]>
[INFO] 
Error:  Tests run: 738, Failures: 1, Errors: 0, Skipped: 4
[INFO] 
[INFO] ------------------------------------------------------------------------

We should fix this as soon as possible
@rohanKanojia rohanKanojia changed the title Fix flaky Fix flaky DefaultSharedIndexInformerTest Apr 22, 2021
@rohanKanojia rohanKanojia changed the title Fix flaky DefaultSharedIndexInformerTest Fix flaky DefaultSharedIndexInformerTest in kubernetes-tests/ Apr 22, 2021
@rohanKanojia rohanKanojia added the component/kubernetes-tests Deals with the kubernetes-tests label Apr 22, 2021
@rohanKanojia rohanKanojia mentioned this issue Apr 25, 2021
Merged
11 tasks
@rohanKanojia
Copy link
Member Author

rohanKanojia commented May 12, 2021 •
edited
Loading

I'm not sure whether it's due to recent changes in SharedInformer API. I'm not able to reproduce it on my local machine even after many attempts.

But I saw it again in https://github.com/fabric8io/kubernetes-client/runs/2568190926?check_suite_focus=true

rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue May 12, 2021
@rohanKanojia
Fix fabric8io#3036: Fix flaky lastResourceVersion failure in DefaultS…
aa3494f 
…haredIndexInformerTest

Add 1 second wait time to lastResourceVersion in
testAllNamespacedInformer() to sync just like done in testNamespacedPodInformer() and
testInformerWithNamespaceAndNameConfigured()
@rohanKanojia rohanKanojia mentioned this issue May 12, 2021
Merged
11 tasks
manusa pushed a commit that referenced this issue May 13, 2021
@rohanKanojia @manusa
Fix #3036: Fix flaky lastResourceVersion failure in DefaultSharedInde…
ac5fb5a 
…xInformerTest

Add 1 second wait time to lastResourceVersion in
testAllNamespacedInformer() to sync just like done in testNamespacedPodInformer() and
testInformerWithNamespaceAndNameConfigured()
ddl-audi pushed a commit to ddl-audi/kubernetes-client that referenced this issue May 14, 2021
@rohanKanojia @ddl-audi
Fix fabric8io#3036: Fix flaky lastResourceVersion failure in DefaultS…
09ed7d4 
…haredIndexInformerTest

Add 1 second wait time to lastResourceVersion in
testAllNamespacedInformer() to sync just like done in testNamespacedPodInformer() and
testInformerWithNamespaceAndNameConfigured()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
component/kubernetes-tests Deals with the kubernetes-tests
Projects
None yet
Milestone
No milestone
1 participant
@rohanKanojia