Upgrade TLS Version in Mock Server to 1.2 #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Apr 24, 2021
|
Any idea what the test failure in Sonar is all about? 🤔 |
|
Sorry, we need to fix this flaky test #3036 . I've restarted workflow |
|
No worries. Not sure how I can improve the coverage on the code I've changed though. Any ideas? |
|
I couldn't find a test for any of these classes. I'm not sure if we should add tests in the scope of this PR or not. |
|
@rohanKanojia I'm not sure I'm qualified (or have the knowledge) to write tests for all of the classes, to be honest... |
|
SonarCloud Quality Gate failed. |
|
No problem, your change is not so big. If required, maintainers can add tests as well. |
grgrzybek
added a commit
to jboss-fuse/kubernetes-client
that referenced
this pull request
Jul 16, 2021
Upgrade TLS Version in Mock Server to 1.2 (fabric8io#3039)
grgrzybek
added a commit
to jboss-fuse/kubernetes-client
that referenced
this pull request
Jul 16, 2021
Upgrade TLS Version in Mock Server to 1.2 (fabric8io#3039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #3038, this PR aims to upgrade the TLS version of
KubernetesMockServerto 1.2, given that Oracle deprecated 1.0 and 1.1 in some JDK versions. I ended up upgrading it in all mocks servers so that it remains consistent throughout the codebase.Type of change
test, version modification, documentation, etc.)
Checklist