Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WatchListDeletable does not properly implement Waitable #3278

Closed
shawkins opened this issue Jun 28, 2021 · 0 comments
Closed

WatchListDeletable does not properly implement Waitable #3278

shawkins opened this issue Jun 28, 2021 · 0 comments
Assignees
Milestone

Comments

@shawkins
Copy link
Contributor

shawkins commented Jun 28, 2021

The current expectation, and even after the proposed changes for #3271, a list is not waitable - only a single resource.

This can be addressed by changing

public interface WatchListDeletable<T, L> extends VersionWatchAndWaitable<T>

to

public interface WatchListDeletable<T, L> extends Watchable<Watcher<T>>, Versionable<WatchAndWaitable<T>>

Or I can generalize the logic in #3274 to support waiting on a list.

@shawkins shawkins self-assigned this Jun 28, 2021
@manusa manusa added this to the 5.5.0 milestone Jun 29, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 29, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 29, 2021
@manusa manusa closed this as completed in 55a98c0 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants