Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement waiting for lists #3285

Closed
shawkins opened this issue Jun 29, 2021 · 1 comment · Fixed by #3286
Closed

Implement waiting for lists #3285

shawkins opened this issue Jun 29, 2021 · 1 comment · Fixed by #3286
Assignees
@shawkins

Comments

@shawkins
Copy link
Contributor

Related to #3278 it would be good if wait methods were available off of the list context.

I propose:

List<T> waitUntilListCondition(Predicate<List<T>> condition, long amount, TimeUnit timeUnit);

In addition it would be good if there were versions of the wait methods that also returned futures so that dependent code, like the NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl did not need to create threads that will simply wait.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 30, 2021
@shawkins
fix fabric8io#3285: adding waiting for list contexts
3fb3fc8 
also adds methods to directly return wait futures, to expose these the
resource handler generation was simplified
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 30, 2021
@shawkins
fix fabric8io#3285: adding waiting for list contexts
8d7d9c2 
also adds methods to directly return wait futures, to expose these the
resource handler generation was simplified
@shawkins
Copy link
Contributor Author

A concrete proposal is #3286

@rohanKanojia @manusa let me know your thoughts.

@shawkins shawkins mentioned this issue Jun 30, 2021
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 30, 2021
@shawkins
fix fabric8io#3285: adding waiting for list contexts
6444b41 
also simplifies the resourcehandler generation
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 30, 2021
@shawkins
fix fabric8io#3285: adding waiting for list contexts
d661f2f 
also simplifies the resourcehandler generation
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jul 6, 2021
@shawkins
fix fabric8io#3285: adding waiting for list contexts
54bf5c3
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jul 6, 2021
@shawkins
fix fabric8io#3285: adding waiting for list contexts
7c011b2
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jul 14, 2021
@shawkins
fix fabric8io#3285: adding waiting for list contexts
411e8ae 
also updating existing logic to use the wait methods
@manusa manusa linked a pull request Jul 20, 2021 that will close this issue
fix #3285: adding waiting for list contexts #3286
Merged
11 tasks
manusa pushed a commit that referenced this issue Jul 21, 2021
@shawkins @manusa
fix #3285: adding waiting for list contexts
8ed9692 
also updating existing logic to use the wait methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #3285: adding waiting for list contexts shawkins/kubernetes-client
1 participant
@shawkins