CRD generator holds onto outdated class information #3442
Assignees
Milestone
Comments
metacosm
added a commit
that referenced
this issue
Sep 3, 2021
This is needed when classes might have been reloaded since the last generation round. If we were to hold onto already generated TypeDefs, we would get an outdated CRD. While this isn't a typical scenario, this situation occurs during Quarkus live reload. Fixes #3442
metacosm
added a commit
that referenced
this issue
Sep 3, 2021
This is needed when classes might have been reloaded since the last generation round. If we were to hold onto already generated TypeDefs, we would get an outdated CRD. While this isn't a typical scenario, this situation occurs during Quarkus live reload. Fixes #3442
11 tasks
metacosm
added a commit
that referenced
this issue
Sep 7, 2021
This is needed when classes might have been reloaded since the last generation round. If we were to hold onto already generated TypeDefs, we would get an outdated CRD. While this isn't a typical scenario, this situation occurs during Quarkus live reload. Fixes #3442
manusa
pushed a commit
that referenced
this issue
Sep 8, 2021
This is needed when classes might have been reloaded since the last generation round. If we were to hold onto already generated TypeDefs, we would get an outdated CRD. While this isn't a typical scenario, this situation occurs during Quarkus live reload. Fixes #3442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If some classes are reloaded and CRD generation is requested again, it's possible that the associated information held in the
DefinitionRepositorywill be outdated thus leading in improper CRD generation. The solution is to be able to request theDefinitionRepositoryto clear its held data when needed from theCRDGenerator. Note that this also requires a fix in sundrio since right now, theDefinitionRepository.clearmethod only clears existing definitions, notTypeDefsuppliers which might be used to regenerate some of the definitions. However, since these suppliers also reference older versions of the classes, it's therefore not enough to just clear the definitions. As a result, fixing this issue will need #3438 to be merged first (or, alternatively, sundrio 0.40.2 with a backported fix to be released).The text was updated successfully, but these errors were encountered: