Make sure new CRDGenerator instances start with a clean generation context #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Sep 3, 2021
This is needed when classes might have been reloaded since the last generation round. If we were to hold onto already generated TypeDefs, we would get an outdated CRD. While this isn't a typical scenario, this situation occurs during Quarkus live reload. Fixes #3442
|
Kudos, SonarCloud Quality Gate passed! |
manusa
approved these changes
Sep 7, 2021
rohanKanojia
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3442
Builds on top of #3438 which would need to be merged first before merging this PR.
Type of change
test, version modification, documentation, etc.)
Checklist