Fix #3016: Use scheduleWithFixedDelay for resync task execution #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Apr 21, 2021
8 tasks
rohanKanojia
force-pushed
the
pr/issue3016
branch
from
94709d3
to
b106bfb
Compare
rohanKanojia
force-pushed
the
pr/issue3016
branch
3 times, most recently
from
655f827
to
5f4f256
Compare
manusa
reviewed
Apr 30, 2021
...rnetes-client/src/test/java/io/fabric8/kubernetes/client/informers/cache/ControllerTest.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Apr 30, 2021
| @@ -248,7 +252,7 @@ void testControllerRunsReyncFunctionExpectedNumberOfTime() throws InterruptedExc | |||
| Executable controllerRun = newControllerRun(controller); | |||
| assertDoesNotThrow(controllerRun); | |||
| // We give an extra cycle to avoid clock inaccurracy interruptions | |||
+ When using `resyncExecutor.scheduleAtFixedRate` we're seeing inconsistent resync intervals since it doesn't wait for previous task to be terminated. Hence using `resyncExecutor.scheduleWithFixedDelay` instead. + Minor changes in ControllerTest regarding resync expectations/wait time
rohanKanojia
force-pushed
the
pr/issue3016
branch
from
5f4f256
to
e4da6aa
Compare
|
Kudos, SonarCloud Quality Gate passed! |
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3016
resyncExecutor.scheduleAtFixedRatewe're seeing inconsistentresync intervals since it doesn't wait for previous task to be
terminated. Hence using
resyncExecutor.scheduleWithFixedDelayinstead.don't use scheduled reflector relist since Fix #2812: SharedIndexInformer EventHandler sees double updates at resync interval #2964
Type of change
test, version modification, documentation, etc.)
Checklist