Fix #3024 removing any onClose action #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
shawkins
changed the title
11 tasks
oscerd
approved these changes
Apr 28, 2021
rohanKanojia
approved these changes
Apr 30, 2021
manusa
reviewed
Apr 30, 2021
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/informers/cache/Reflector.java
Outdated
Show resolved
Hide resolved
11 tasks
|
The new conflict has to do with the merge of #3031, |
informer-watch # Conflicts: # kubernetes-client/src/main/java/io/fabric8/kubernetes/client/informers/cache/Controller.java
|
Should be up-to-date now. |
|
Kudos, SonarCloud Quality Gate passed! |
|
Relates to: #2010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
further cleanups to the Informer onClose behavior
We don't need to call anything for the non-exceptional onClose. It will only be triggered by the Reflector calling Watch.close. Every other closing event will go through the exceptional onClose. Of those calls we only want special handling for http_gone. - everything else we want to simply let watch framework keep retrying.
This supersedes the reflector changes from #3029
Type of change
test, version modification, documentation, etc.)
Checklist