Typeguard requirement is for old version #2043
Assignees
Labels
enhancement
New feature or request
Comments
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this issue
Dec 5, 2023
Summary: Attempt to solve/mitigate facebook#2043 Differential Revision: D51853729
|
Hi @jakeBass I'm working on seeing if we can upgrade, but there are some internal complications. In the meantime, if you run |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this issue
Dec 5, 2023
Summary: Attempt to solve/mitigate facebook#2043 We stopped pinning typeguard to 2.13.3, but gracefully failing if it doesn't have that version manually changes the version. This is important so ax can install in a standard way without conflicting with user's other dependencies. Differential Revision: D51853729
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this issue
Dec 5, 2023
) Summary: Attempt to solve/mitigate facebook#2043 We stopped pinning typeguard to 2.13.3, but gracefully failing if it doesn't have that version manually changes the version. This is important so ax can install in a standard way without conflicting with user's other dependencies. Reviewed By: mpolson64 Differential Revision: D51853729
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this issue
Dec 5, 2023
) Summary: Attempt to solve/mitigate facebook#2043 We stopped pinning typeguard to 2.13.3, but gracefully failing if it doesn't have that version manually changes the version. This is important so ax can install in a standard way without conflicting with user's other dependencies. Reviewed By: mpolson64 Differential Revision: D51853729
facebook-github-bot
pushed a commit
that referenced
this issue
Dec 6, 2023
Summary: Pull Request resolved: #2044 Attempt to solve/mitigate #2043 We stopped pinning typeguard to 2.13.3, but gracefully failing if it doesn't have that version manually changes the version. This is important so ax can install in a standard way without conflicting with user's other dependencies. Reviewed By: mpolson64 Differential Revision: D51853729 fbshipit-source-id: b131d2751474ca3d9303853119744e5148fe8cec
|
Thanks so much @danielcohenlive, really appreciate the quick response! Do you know when |
|
That's wonderful, thanks so much again @danielcohenlive! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi folks! It appears that Ax still has pinned the typeguard requirement to an ancient version (from Dec 2021). It's getting increasingly hard to align this requirement with requirements from other OSS for a more modern version of
typeguard. Are there any plans to update the typeguard requirement, or to remove it?The text was updated successfully, but these errors were encountered: