Use inspect to support typeguard version being overridden #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51853729 |
danielcohenlive
force-pushed
the
export-D51853729
branch
from
0de28fc
to
2e9971a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51853729 |
danielcohenlive
force-pushed
the
export-D51853729
branch
from
2e9971a
to
34cf753
Compare
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Dec 5, 2023
) Summary: Attempt to solve/mitigate facebook#2043 We stopped pinning typeguard to 2.13.3, but gracefully failing if it doesn't have that version manually changes the version. This is important so ax can install in a standard way without conflicting with user's other dependencies. Reviewed By: mpolson64 Differential Revision: D51853729
|
This pull request was exported from Phabricator. Differential Revision: D51853729 |
) Summary: Attempt to solve/mitigate facebook#2043 We stopped pinning typeguard to 2.13.3, but gracefully failing if it doesn't have that version manually changes the version. This is important so ax can install in a standard way without conflicting with user's other dependencies. Reviewed By: mpolson64 Differential Revision: D51853729
danielcohenlive
force-pushed
the
export-D51853729
branch
from
34cf753
to
f3125bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51853729 |
|
This pull request has been merged in a03bd24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Attempt to solve/mitigate #2043
Differential Revision: D51853729