Delete legacy get posterior mean #2613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This has been deprecated for quite some time. We can safely remove it. I left the storage backwards compatibility code in-place. We can still load old `ListSurrogate` objects as a `Surrogate`. Differential Revision: D60393343
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60396661 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
==========================================
- Coverage 95.21% 95.20% -0.01%
==========================================
Files 495 492 -3
Lines 47721 47649 -72
==========================================
- Hits 45436 45365 -71
+ Misses 2285 2284 -1 ☔ View full report in Codecov by Sentry. |
Summary: Pull Request resolved: facebook#2613 Legacy models have been deprecated for a while and they're being removed one by one. This particular one was being used to construct MC-PosteriorMean (qSimpleRegret) and was used only in `compute_posterior_pareto_frontier`. Updated the usage with MBM equivalent and removed the code. Reviewed By: esantorella Differential Revision: D60396661
|
This pull request was exported from Phabricator. Differential Revision: D60396661 |
saitcakmak
force-pushed
the
export-D60396661
branch
from
f4a7433
to
3a489c8
Compare
|
This pull request has been merged in 8587b30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Legacy models have been deprecated for a while and they're being removed one by one. This particular one was being used to construct MC-PosteriorMean (qSimpleRegret) and was used only in
compute_posterior_pareto_frontier. Updated the usage with MBM equivalent and removed the code.Differential Revision: D60396661