Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete legacy get posterior mean #2613

Closed
wants to merge 2 commits into from
Closed

Delete legacy get posterior mean #2613

wants to merge 2 commits into from

Commits on Jul 29, 2024

  1. Delete ListSurrogate 

    Summary:
This has been deprecated for quite some time. We can safely remove it.

I left the storage backwards compatibility code in-place. We can still load old `ListSurrogate` objects as a `Surrogate`.

Differential Revision: D60393343
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    f8ae59d View commit details
    Browse the repository at this point in the history

  2. Delete legacy get posterior mean (facebook#2613) 

    Summary:
Pull Request resolved: facebook#2613

Legacy models have been deprecated for a while and they're being removed one by one. This particular one was being used to construct MC-PosteriorMean (qSimpleRegret) and was used only in `compute_posterior_pareto_frontier`. Updated the usage with MBM equivalent and removed the code.

Reviewed By: esantorella

Differential Revision: D60396661
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    3a489c8 View commit details
    Browse the repository at this point in the history