Remove tracking metrics setup for noisy benchmarks #2706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61415525 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
==========================================
- Coverage 95.39% 95.39% -0.01%
==========================================
Files 492 491 -1
Lines 47920 47744 -176
==========================================
- Hits 45715 45547 -168
+ Misses 2205 2197 -8 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D61415525 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 23, 2024
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Differential Revision: D61415525
esantorella
force-pushed
the
export-D61415525
branch
from
eef05c1
to
e78df7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61415525 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Differential Revision: D61415525
esantorella
force-pushed
the
export-D61415525
branch
from
e78df7e
to
4d25a32
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61415525 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Differential Revision: D61415525
esantorella
force-pushed
the
export-D61415525
branch
2 times, most recently
from
b95aca1
to
e48f017
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Reviewed By: Balandat Differential Revision: D61415525
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Differential Revision: D61415525 Reviewed By: Balandat
|
This pull request was exported from Phabricator. Differential Revision: D61415525 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 25, 2024
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Reviewed By: Balandat Differential Revision: D61415525
esantorella
force-pushed
the
export-D61415525
branch
from
e48f017
to
881fad5
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 26, 2024
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Differential Revision: D61415525 Reviewed By: Balandat
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Differential Revision: D61404056 Reviewed By: saitcakmak
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Reviewed By: Balandat Differential Revision: D61415525
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Differential Revision: D61415525 Reviewed By: Balandat
|
This pull request was exported from Phabricator. Differential Revision: D61415525 |
esantorella
force-pushed
the
export-D61415525
branch
from
881fad5
to
3c97e89
Compare
|
This pull request has been merged in 9f81de7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: No longer needed after the changes in the previous diff.
Differential Revision: D61415525